'Reset to Defaults' tries setting up too many variables

[krystian-hebel]

Component

Dasharo firmware

Device

PC Engines APU2, PC Engines APU3, PC Engines APU4, PC Engines APU6, QEMU Q35 Emulator, other

Dasharo version

Noticed on Dasharo/edk2@f4b94d7, but probably applies to pre-rebased edk2 as well

Dasharo Tools Suite version

No response

Brief summary

Default values for variables that aren't used by given platform are restored, and may fail validity checks. An example of such setting is CPU Throttling Threshold on QEMU Q35 and probably PC Engines platforms as well.

How reproducible

100%

How to reproduce

• build QEMU from Dasharo/coreboot@71450da (./build.sh q35)
• boot and enter setup
• restore defaults (F9) and try to save them (F10)

Expected behavior

Defaults restored and saved without errors

Actual behavior

Error saying that CPU throttling value is out of range

Screenshots

Additional context

List of variables introduced in Dasharo/DasharoModulePkg#45 and updated in Dasharo/DasharoModulePkg#48 may be extended to include PCD name (or bolean value based on it? This would allow for non-trivial requirements in the future) that controls whether the menu is shown (e.g. PcdShowCpuThrottlingThreshold for this case, similarly for others).

Solutions you've tried

Error can be discarded, which allows to reset other settings. Trying to get to higher menu level by pressing ESC when on Power Management Options page immediately exits setup app. That page isn't accessible by traversing the menu.

[pietrushnic]

@macpijan @BeataZdunczyk I guess this should go to v0.9.1, but is there no such milestone yet?

[krystian-hebel]

This touches more platforms than anticipated: Dasharo/DasharoModulePkg#50 (comment)

[miczyg1]

That is why Dasharo/DasharoModulePkg#50 must land to fix this (and possibly future occurrences)