Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments in ConfigHandler rewrite themselves #64

Open
DRACTION opened this issue Feb 25, 2024 · 3 comments
Open

Comments in ConfigHandler rewrite themselves #64

DRACTION opened this issue Feb 25, 2024 · 3 comments

Comments

@DRACTION
Copy link

1.18.2 - 1.18.8

For Example, We have:

            DOG_GREET_OWNER_LIMIT = builder
                .comment("Specify how many dogs can greet you when you approach more than one missing dog.")
                .comment("The remaning dogs will remain in their position.")
                .comment("To disable the limit, set this to any non-positive integer.")
                .comment("Although this will cause all of your dogs to stand up and greet.")
                .comment("YOU HAVE BEEN WARNED! :)")
                .translation("doggytalents.dog_greet_owner_limit")
                .defineInRange("dog_greet_owner_limit", 5, Integer.MIN_VALUE, Integer.MAX_VALUE);

Result:

	#YOU HAVE BEEN WARNED! :)
	#Range: > -2147483648
	dog_greet_owner_limit = 5

Probably solution:

            DOG_GREET_OWNER_LIMIT = builder
                .comment("Specify how many dogs can greet you when you approach more than one missing dog.\n"
                + "The remaning dogs will remain in their position.\n"
                + "To disable the limit, set this to any non-positive integer.\n"
                + "Although this will cause all of your dogs to stand up and greet.\n"
                + "YOU HAVE BEEN WARNED! :)")
                .translation("doggytalents.dog_greet_owner_limit")
                .defineInRange("dog_greet_owner_limit", 5, Integer.MIN_VALUE, Integer.MAX_VALUE);

Result:

	#Specify how many dogs can greet you when you approach more than one missing dog.
	#The remaning dogs will remain in their position.
	#To disable the limit, set this to any non-positive integer.
	#Although this will cause all of your dogs to stand up and greet.
	#YOU HAVE BEEN WARNED! :)
	#Range: > -2147483648
	dog_greet_owner_limit = 5
@DashieDev
Copy link
Owner

DashieDev commented Feb 25, 2024

Hmmm... Which Minecraft/ Forge Version are you referring to? Since this behavior is kinda new and seems not to be what happened on my side (Using Forge 47.1.0 on 1.20.1) ....

@DashieDev
Copy link
Owner

Oh okay now I just noticed it again and it is 1.18.2, so I guess only 1.18.2 have that behavior instead of the expected one...

@DRACTION
Copy link
Author

Forge 40.2.17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants