Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make OPTIONS handler optional #4

Open
H0R5E opened this issue May 9, 2023 · 0 comments
Open

Make OPTIONS handler optional #4

H0R5E opened this issue May 9, 2023 · 0 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request feature requires a minor version update

Comments

@H0R5E
Copy link
Member

H0R5E commented May 9, 2023

Currently, buildRouter requires the function URL for the options handler created by buildOptions.

It might be the case that a user wants to handle the OPTIONS methods within the SSR server itself, therefore the optionsURL argument to buildRouter should be optional.

Note that we could still automate the ALLOWED_ORIGINS environment variable to allow users to include it in the SSR server. This variable is poorly documented right now anyway.
@H0R5E H0R5E added documentation Improvements or additions to documentation enhancement New feature or request feature requires a minor version update labels May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request feature requires a minor version update
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@H0R5E