Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy Docker images in parallel when mirroring to ECR #6679

Open
achave11-ucsc opened this issue Nov 1, 2024 · 2 comments
Open

Copy Docker images in parallel when mirroring to ECR #6679

achave11-ucsc opened this issue Nov 1, 2024 · 2 comments
Labels
- [priority] Medium enh [type] New feature or request infra [subject] Project infrastructure like CI/CD, build and deployment scripts needs spike [process] Needs to be spiked before it can be solved orange [process] Done by the Azul team perf [subject] Performance, efficiency or cost

Comments

@achave11-ucsc
Copy link
Member

achave11-ucsc commented Nov 1, 2024

@hannes-ucsc: "We have around ten images to copy. When we used docker pull and docker push to copy them, doing all images in parallel (using Terraforms default concurrency) would overload dockerd/containerd so we added a semaphore to serialize that part. Now that we use skopeo to copy images, we may want to remove the semaphore again or set it to a higher initial value for increased concurrency."

@achave11-ucsc achave11-ucsc added the orange [process] Done by the Azul team label Nov 1, 2024
@hannes-ucsc hannes-ucsc changed the title Semaphore maybe redundant now that we use Skopeo to copy images Images are not copied in parallel Nov 2, 2024
@hannes-ucsc
Copy link
Member

Spike to test and measure the running time of deploying tempdev.shared with an initial value of 1, 5 and 10, deleting all images from ECR before every run.

@hannes-ucsc hannes-ucsc added bug [type] A defect preventing use of the system as specified infra [subject] Project infrastructure like CI/CD, build and deployment scripts perf [subject] Performance, efficiency or cost enh [type] New feature or request and removed bug [type] A defect preventing use of the system as specified labels Nov 6, 2024
@hannes-ucsc hannes-ucsc changed the title Images are not copied in parallel Copy Docker images in parallel when mirroring to ECR Nov 6, 2024
@hannes-ucsc hannes-ucsc added - [priority] Medium needs spike [process] Needs to be spiked before it can be solved labels Nov 6, 2024
@hannes-ucsc
Copy link
Member

Skopeo copies six layers in parallel by default. However, many images have one large layer and many small ones, so copying multiple images in parallel might still be worth it. Hence the spike.

@hannes-ucsc hannes-ucsc removed their assignment Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
- [priority] Medium enh [type] New feature or request infra [subject] Project infrastructure like CI/CD, build and deployment scripts needs spike [process] Needs to be spiked before it can be solved orange [process] Done by the Azul team perf [subject] Performance, efficiency or cost
Projects
None yet
Development

No branches or pull requests

2 participants