-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
check_branch.py fails on chained PRs #6906
Comments
Spike to diagnose. |
The script expects that the PR's target branch is associated with a shared deployment, as configured in
When creating a chained PR, the ideal behavior would be for the script to select the deployment associated with the target branch of the base PR (if the base PR is also chained, repeat this process until a non-chained base PR is reached). I presume this is possible via the GitHub API, but it might be overkill to go about implementing it. My impression is that most chained PR's eventually lead to |
@hannes-ucsc: "Agreed, we can assume that chained PRs always target develop, albeit indirectly." |
For demo, attempt to reproduce. |
[edit: @hannes-ucsc]
This is a regression from 64b1419 (Fix: GitHub CI workflow selects dev when building prod branch (#5428, #6823, PR #6818)).
The text was updated successfully, but these errors were encountered: