Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor TreeGrid to have typed items and data #1175

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Refactor TreeGrid to have typed items and data #1175

wants to merge 1 commit into from

Conversation

tjennison-work
Copy link
Collaborator

  • Both items and data can be typed separately, though it mostly only makes sense to customize one or the other. EntityGroup criteria have generic data and typed items to store extra associated info such as the entity group but the study pages just have typed data because it's simpler.
  • Pass the item to rowCustomization callbacks since it contains the data as well. Type it appropriately.
  • Split the root children out so there's no need for an awkward root object.

@tjennison-work
Refactor TreeGrid to have typed items and data
1006db5 
* Both items and data can be typed separately, though it mostly
  only makes sense to customize one or the other. EntityGroup
  criteria have generic data and typed items to store extra
  associated info such as the entity group but the study pages
  just have typed data because it's simpler.
* Pass the item to rowCustomization callbacks since it contains
  the data as well. Type it appropriately.
* Split the root children out so there's no need for an awkward
  root object.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tjennison-work