You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the current interface for Sparkle, we are passing Writers as writers: List[Writer]. it should be refactored to writers: List[type[Writer]], similar to readers argument.
Regarding type List[type[Writer]], it can be refactored to an Enum; So instead of List[type[Writer]], we accept List[WriterType] which WriterType is an enum. Same should happen for reader. (Created #24 another issue)
Reason is initiaizing a Writer requires a SparkSession which we decided to let Sparkle create that session; So it means during initializing a Sparkle app, we don't have access to SparkSession yet and Sparkle should be responsible for initializing Readers and Writers.
The text was updated successfully, but these errors were encountered:
@farbodahm didn't we suggest in our call to instead of passing writers: List[type[Writer]], to use some kind of Enum or TypedDict instead, to hide implementation away from final user and avoid unnecessary imports?
In the current interface for Sparkle, we are passing Writers as
writers: List[Writer]
. it should be refactored towriters: List[type[Writer]]
, similar toreaders
argument.Regarding type(Created #24 another issue)List[type[Writer]]
, it can be refactored to an Enum; So instead ofList[type[Writer]]
, we acceptList[WriterType]
whichWriterType
is an enum. Same should happen for reader.Reason is initiaizing a Writer requires a SparkSession which we decided to let Sparkle create that session; So it means during initializing a Sparkle app, we don't have access to SparkSession yet and Sparkle should be responsible for initializing Readers and Writers.
The text was updated successfully, but these errors were encountered: