Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Create new project - workflow template not found! #136

Open
goranbs opened this issue Nov 27, 2023 · 1 comment
Open

[Bug]: Create new project - workflow template not found! #136

goranbs opened this issue Nov 27, 2023 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@goranbs
Copy link
Contributor

goranbs commented Nov 27, 2023

Contact details

No response

Current behavior

Create new project and upload workflow template that has some error -> successfully creates the project, but due to backend error when creating the workflow template, the workflow template is not successfully stored in the project.

Expected behavior

Either:

  1. Raise and display error to the user describing what is wrong, and do not create the project
  2. Raise and display warning to user, create the project but go to edit-mode in workflow template so that the user can fix the problem(s) and resubmit the workflow template.

Steps to reproduce

example yaml file to reproduce:

apiVersion: argoproj.io/v1alpha1
kind: Workflow
metadata:
generateName: magma-
spec:
entrypoint: magma-workflow
volumes:
- name: data-volume
emptyDir: {}

templates:
- name: magma-workflow
dag:
tasks:
- name: c1
template: c1
- name: c2
template: c2
arguments:
artifacts:
- name: file
from: "{{dag.tasks.c1.outputs.artifacts.output}}"
- name: c3
template: c3
arguments:
artifacts:
- name: file
from: "{{dag.tasks.c2.outputs.artifacts.output}}"

- name: c1
  inputs:
    artifacts:
    - name: input_folder
      path: /tmp/folder
      raw:
        data: provide input folder
  outputs:
    artifacts:
    - name: output
      path: /tmp/output_file.csv
  container:
    image: magma
    command: [java, -jar]
    args: ["./app.jar -c1 {{inputs.artifacts.input_folder}}"]

- name: c2
  inputs:
    artifacts:
    - name: input_file
      path: /tmp/file
  outputs:
    artifacts:
    - name: output
      path: /tmp/output_file.csv        
  container:
    image: magma
    command: [ java, -jar]
    args: ["./app.jar -c2 {{inputs.artifacts.input_file}}"]

- name: c3
  inputs:
    artifacts:
    - name: input_file
      path: /tmp/file
  outputs:
    artifacts:
    - name: output
      path: /tmp/output_file.csv        
  container:
    image: magma
    command: [ java, -jar]
    args: ["./app.jar -c3 {{inputs.artifacts.input_file}}"]

Environment

  • SIM-PIPE version: stage
  • Platform/OS:
  • Browser:
  • Other:

Screenshots

No response

Logs

No response

@goranbs
Copy link
Contributor Author

goranbs commented Nov 1, 2024

Need to add validation step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants