fix: build fails with "sending never-build-twice request failed" #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The never-build-twice feature assumed that it is not, ever, possible for a single build to result in multiple different builds of the same package with different build IDs. #507 suggest this might actually be a valid outcome (the exact details of why/how are not clear yet). This PR removes that assumption and keeps separate cache entries for each individual build ID in order to reduce the risk of breaking the build. Fixes #507
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #508 +/- ##
==========================================
- Coverage 72.15% 72.05% -0.11%
==========================================
Files 104 104
Lines 5402 5407 +5
==========================================
- Hits 3898 3896 -2
- Misses 1044 1048 +4
- Partials 460 463 +3
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The never-build-twice feature assumed that it is not, ever, possible for a single build to result in multiple different builds of the same package with different build IDs. #507 suggest this might actually be a valid outcome (the exact details of why/how are not clear yet).
This PR removes that assumption and keeps separate cache entries for each individual build ID in order to reduce the risk of breaking the build.
Fixes #507