Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep User secrets out of active memory #179

Open
DavidRieman opened this issue May 30, 2023 · 0 comments
Open

Keep User secrets out of active memory #179

DavidRieman opened this issue May 30, 2023 · 0 comments
Labels
enhancement This task is adding new behavior or performing other refactoring improvements.

Comments

@DavidRieman
Copy link
Owner

Right now while we have a User logged into an active session, the User object is fully in memory. This currently includes their Salt and HashedPassword. However, we have to assume that at some point a malicious actor on the server may find some way to dig into the objects held in memory, and thus retrieve these properties from online session User objects. (From there it's probably trivial to brute force the passwords offline without raising any suspicion from failed login attempts.) We should see if we can reduce this additional attack surface. One way that should help would be to move authentication-related data out to its own entries in the DB, then, only when auth is successful is the resulting User object loaded, and that won't pin the Salt or HashedPassword around in memory anymore.

(Note this impacts how PW Change #43 should get fixed.)

@DavidRieman DavidRieman added the enhancement This task is adding new behavior or performing other refactoring improvements. label May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This task is adding new behavior or performing other refactoring improvements.
Projects
None yet
Development

No branches or pull requests

1 participant