Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users ANSI <%code%> shenanigans possible #187

Open
DavidRieman opened this issue Aug 20, 2024 · 0 comments
Open

Users ANSI <%code%> shenanigans possible #187

DavidRieman opened this issue Aug 20, 2024 · 0 comments

Comments

@DavidRieman
Copy link
Owner

(Splitting issue from #107.)

Currently a user can type things like say Haha<%up%> GHOST in their communications to have people get "cursor up" commands injected into their output. As-is, this would wreak havoc as clients which support cursor movements (like zMud) will honor the cursor movement command. Basically, this is a class of escape code we should not give a means to replicate through characters which pass user input sanitization processes. The left/right/up/down cursor movement cases are being removed immediately from AnsiHandler but we need to carefully consider the rest of the cases. Like cls is surely problematic, and possibly hidden could find malicious use, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant