Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the New Mod version to say the Name of the new version not the File Name #14

Open
ZaneDragonBorn opened this issue Sep 7, 2020 · 1 comment
Labels
enhancement Improvement to current features on hold idle

Comments

@ZaneDragonBorn
Copy link

Untitled
Like that ^ because it's more accurate than the File Name.

@Davoleo Davoleo added enhancement Improvement to current features help wanted Extra attention is needed labels Sep 7, 2020
@Davoleo
Copy link
Owner

Davoleo commented Sep 7, 2020

I don't know if it's possible to strip the actual version number
as you see when you upload files on curseforge there isn't any field called "Version" where you write the actual package version, which means that Curseforge itself doesn't store packages with a version but only differentiate them through names.

This means that anyone is able to upload them with any pattern they want, some may use a constant pattern like "ProjectName V" but other user may use a completly different pattern or not write the version at all#
for example though I usually use "ProjectName - " or "ProjectName-" which would already make a string search useless

I think it's most simple to just keep it like this until overwolf maybe introduces an actual API that provides version number for packages

If you meant to use the actual full name of the release, then that may be possible although these are the two reasons I avoided it since right now:

  • Sometimes API calls to that field return undefined which means I have no information to write in the embed (although I could use the filename as a fallback yes)
  • A version number could be not present at all, as I mentioned earlier, you can include whatever you want in that field on curseforge and some people don't actually include version numbers there

@Davoleo Davoleo added on hold idle and removed help wanted Extra attention is needed labels Apr 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement to current features on hold idle
Projects
None yet
Development

No branches or pull requests

2 participants