Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve display of "Download link" if it's null in Project File #32

Open
Bruneitor123 opened this issue Dec 20, 2024 · 2 comments
Open
Labels
enhancement Improvement to current features

Comments

@Bruneitor123
Copy link

General Information

This problem occurred with some new mods. I wasn't able to replicate the problem with older mods (even with recent updates.

Describe the bug:
When using either /latest <project-id> or whenever /schedule add runs... Some project ids show the Download hyperlink as null: [Download](null). I'll describe the problem using /latest as it more likely does have the same mechanism. I couldn't find a specific pattern to discover the actual error, so I assumed that it happened only in a few new mods.

To Reproduce:

  1. Invite the bot to the Discord server and give appropriate permissions.
  2. Use /latest <project-id> and insert one of these projects: 1162729 | 1162748 | 1136088 (these are examples, maybe more of them return null?)
  3. Bot returns with the expected response, but with the hyperlink of "Download" being broken, showing "[Download](null)".

Expected behavior:
Bot sends an actual hyperlink to the download of the file and not a broken one.


Additional Information

Screenshots (if available):
image
image

@Bruneitor123 Bruneitor123 added the bug Something isn't working label Dec 20, 2024
@Davoleo
Copy link
Owner

Davoleo commented Dec 22, 2024

That could probably be handled better by removing the link altogether; although if the file is not available through the API it's not something I can do much about.
There might be different reasons for which the file is unavailable, such as having disabled 3rd party distribution in the project settings, can you check if that's the case?

@Davoleo Davoleo added enhancement Improvement to current features and removed bug Something isn't working labels Dec 22, 2024
@Davoleo Davoleo changed the title Download link of Project/s is null Improve display of "Download link" if it's null Project File Dec 22, 2024
@Davoleo Davoleo changed the title Improve display of "Download link" if it's null Project File Improve display of "Download link" if it's null in Project File Dec 22, 2024
@Bruneitor123
Copy link
Author

Hey, after checking with one of the projects that does have a [null] case, 3rd party distributions are indeed disabled. I haven't modified the field yet, but that could be one of the causes, thanks for noticing!

It would be also cool if there are more customizable options such as removing the link as you said.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement to current features
Projects
None yet
Development

No branches or pull requests

2 participants