Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android Collapsing toolbar #163

Closed
2 of 20 tasks
ManonPolle opened this issue Jan 17, 2023 · 2 comments
Closed
2 of 20 tasks

Android Collapsing toolbar #163

ManonPolle opened this issue Jan 17, 2023 · 2 comments
Labels
android 🟢 Related to android components 🧩 Related to components dev issues created ✔️ Here to say that all developers issues had been created enhancement 🚀 New feature or request

Comments

@ManonPolle
Copy link
Contributor

Duplicates ❌

  • I have searched the existing issues

Libraries

  • Vitamin Web UI Kit
  • Vitamin Android UI Kit
  • Vitamin iOS UI Kit
  • Vitamin Icons
  • Vitamin Assets
  • Vitamin Core theme (Light mode)
  • Vitamin Core theme (Dark mode)
  • Vitamin Base colors palette
  • Vitamin Extras kit
  • Not related to one Figma library

Summary 💡

Here the request for having a collapsing toolbar

https://decathlon-design.slack.com/archives/C01M569MN8L/p1670941275534269

It is link to the issue #142

Dependencies 📦

No response

Examples 🌈

No response

Motivation 🔦

No response

New 🆕

  • Validated in a grooming session

Backlog 📋

  • Has a good summary
  • Has example link(s)

Design in progress 🏗

  • Analysis (functional & technical)
  • Design refinement
  • Dev qualification (properties, breakpoints, tokens etc.)
  • Documentation refinement (inside the Figma branch)

Design review 👀

  • Figma branch merged
  • Documentation review _(and move the documentation into Vitamin Documentation Figma file)
@ManonPolle ManonPolle added enhancement 🚀 New feature or request run 💨 labels Jan 17, 2023
@lauthieb lauthieb added the components 🧩 Related to components label Jan 18, 2023
@lauthieb lauthieb moved this from 🆕 New to 📋 Backlog in Decathlon Design System Jan 18, 2023
@lauthieb lauthieb moved this from 📋 Backlog to 🆕 New in Decathlon Design System Jan 18, 2023
@lauthieb lauthieb moved this from 🆕 New to 📋 Backlog in Decathlon Design System Jan 18, 2023
@lauthieb
Copy link
Member

Decision in grooming session:

  • Validated by @Decathlon/design-system-core-team-design
  • To do in vitamin-android & vitamin-compose

@lauthieb lauthieb moved this from 📋 Backlog to 🔖 Dev to do in Decathlon Design System Jan 19, 2023
@lauthieb lauthieb moved this from 🔖 Dev to do to 👍 Design done in Decathlon Design System Jan 20, 2023
@lauthieb lauthieb added the android 🟢 Related to android label Feb 6, 2023
This was referenced Feb 7, 2023
Open
Open
@lauthieb
Copy link
Member

lauthieb commented Feb 7, 2023

As it's a validated & dev only issue, I close this issue here and just split this subject into two issues for Androdi & Compose implementations:

@lauthieb lauthieb closed this as completed Feb 7, 2023
@github-project-automation github-project-automation bot moved this from 👍 Design done to ✅ Done in Decathlon Design System Feb 7, 2023
@lauthieb lauthieb added the dev issues created ✔️ Here to say that all developers issues had been created label Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
android 🟢 Related to android components 🧩 Related to components dev issues created ✔️ Here to say that all developers issues had been created enhancement 🚀 New feature or request
Projects
Decathlon Design System
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lauthieb @ManonPolle