Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong behavior with TranslateTextOptions::TAG_HANDLING xml and notranslate tag #47

Open
VincentLanglet opened this issue May 23, 2024 · 3 comments
Labels
api change Requires changes to the DeepL API bug Something isn't working

Comments

@VincentLanglet
Copy link
Contributor

Hi @daniel-jones-deepl,

I discover another bug with the TranslateTextOptions::TAG_HANDLING => xml (But different from #43 (comment))

Translating FR to ES

En seulement 4 mois, l’établissement a généré <strong wg-1="">30k€ de <notranslate>ingresos</notranslate></strong> et a enregistré <strong wg-2="">plus de 80 nouvelles réservations</strong> suite à l’envoi d’e-mails marketing personnalisés

En sólo 4 meses, el establecimiento generó <strong wg-1="">30k€ en <notranslate>ingresos</notranslate></strong> y registró <strong wg-2="">más de 80 nuevas reservas</strong> tras el envío de emails de marketing personalizados.

Translating FR to ES with TranslateTextOptions::TAG_HANDLING => xml

En seulement 4 mois, l’établissement a généré <strong wg-1="">30k€ de <notranslate>ingresos</notranslate></strong> et a enregistré <strong wg-2="">plus de 80 nouvelles réservations</strong> suite à l’envoi d’e-mails marketing personnalisés

<strong wg-1=""> <notranslate>ingresos</notranslate>En sólo 4 meses, el establecimiento generó</strong> <strong wg-1="">30.000 euros</strong> y registró <strong wg-1=""></strong> <strong wg-2="">más de 80 nuevas reservas</strong> tras el envío de correos electrónicos de marketing personalizados.

I would expect a result similar to the first one.

Could you confirm and forward the issue to your backend team ? Thanks.

@daniel-jones-dev
Copy link
Member

HI @VincentLanglet, thanks for the report.
I was able to reproduce the problem by also setting ignore_tags to include notranslate tag. This is indeed a strange problem, some target languages (eg en-US) seem to handle it correctly, others have a similar problem. I've forwarded it to our backend team.

@daniel-jones-dev daniel-jones-dev added bug Something isn't working api change Requires changes to the DeepL API labels May 24, 2024
@myfbone
Copy link

myfbone commented Jul 17, 2024

Same problem with German to Polish language pair

@ricardoaraujo330
Copy link

Same here, please fix it asap 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api change Requires changes to the DeepL API bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants