Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSV Export header order #64

Open
omniproc opened this issue Jan 15, 2019 · 4 comments
Open

CSV Export header order #64

omniproc opened this issue Jan 15, 2019 · 4 comments

Comments

@omniproc
Copy link

omniproc commented Jan 15, 2019

I just noticed that the header of the exported CSV files has the issue that "Trade ID" and "Date" are in the wrong order.

E.g. The header said for the CoinTracking export shows "Date","Trade ID" but the data is formated "Trade ID","Date". This leads to import issues with CoinTracking. Also, as mentioned in https://cointracking.info/import/import_csv/ optional headers, such as "Trade ID" must be placed after the mandatory headers such as "Date". Thus, it's not sufficient to just swap the header. The data needs to be swapped.

EDIT: and I just noticed the date format used in the export is not accepted by CoinTracking.

@DeltaBalances
Copy link
Owner

DeltaBalances commented Jan 15, 2019

When I added cointracking like a year ago it worked as expected.
I guess things have changed in the meantime, as someone mentioned before that the TradeID and Date columns should be switched.
I guess a little oversight slipped into that fix.

I personally don't need to export anything for my taxes, so these services are always a little annoying to test. Looks like i'll have to make a throwaway account again.

I'll look into that date, as this is pretty much a standard format.

@omniproc
Copy link
Author

omniproc commented Jan 15, 2019

I can provide you with the information you need. So far:

  1. Mandatory rows, expected (in that order):
  • Type
  • Buy Amount
  • Buy Currency
  • Sell Amount
  • Sell Currency
  • Fee Amount (optional)
  • Fee Currency (optional)
  • Exchange (optional)
  • Trade Group (optional)
  • Comment (optional)
  • Date
  1. Optional rows that may follow (in that order):
  • Tx-ID
  • Buy Value in your Account Currency
  • Sell Value in your Account Currency
  1. Date format that seems to get accepted and that's used in the example export CSV has the form: DD-MM-YYYY hh:mm:ss

Let me know if you need anything else or when you need me to test the import of the generated files.

@DeltaBalances
Copy link
Owner

I fixed the bad column order, but I don't encounter any errors importing the current date format.

I made a cointracking account and importing some data from a few random wallets seems to work.
Imported at the bottom of this page:

  • Selecting Import CSV for Cointracking (CSV) files.
  • Selecting Custom exchange import for Cointracking (CustomExchange) files.

@omniproc
Copy link
Author

I believe this has to do with the lang. and time/date format setting set in the CT settings. For me that's "german" and a custom time/date format, which seems to also break the import. I'll test those settings and let you know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants