-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Revert "Revert AME buff"" #996
Conversation
This reverts commit e271a5d.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do it!
I've already said before this isn't a good idea without the pending fixed from upstream, but I can't stop you |
We talked about it. We took into consideration what you said. Decided it's worth the risk/reward and we're prepared to undo it if it's too problematic. |
If it breaks, I told you so ¯\_(ツ)_/¯ |
is there any issue i havent seen any problem when not using 1 core ops |
## Mirror of PR #996: [Revert "Revert "Revert AME buff""](DeltaV-Station/Delta-v#996) from <img src="https://avatars.githubusercontent.com/u/131613340?v=4" alt="DeltaV-Station" width="22"/> [DeltaV-Station](https://github.com/DeltaV-Station)/[Delta-v](https://github.com/DeltaV-Station/Delta-v) <aside>PR opened by <img src="https://avatars.githubusercontent.com/u/107660393?v=4" width="16"/><a href="https://github.com/IamVelcroboy"> IamVelcroboy</a> at 2024-03-23 00:07:05 UTC</aside> <aside>PR merged by <img src="https://avatars.githubusercontent.com/u/107660393?v=4" width="16"/><a href="https://github.com/IamVelcroboy"> IamVelcroboy</a> at 2024-03-23 00:16:26 UTC</aside> <sup> `b4fc2e342be6ef395b1ca21f27787ac08a89df59` </sup> --- PR changed 0 files with 0 additions and 0 deletions. The PR had the following labels: - Changes: C# --- <details open="true"><summary><h1>Original Body</h1></summary> > Reverts DeltaV-Station/Delta-v#939 > > We might revert this again if everything burns but it's worth a shot. Let's gooo > > > **Changelog** > 🆑 Velcroboy > - tweak: Reverted AME buff. AME will require more than 1 core again to function properly. </details> Co-authored-by: Velcroboy <[email protected]>
# Description - Adjusts the "danger" status threshold in Air Alarms to 20 kPa, resulting in "warning" status at the expected 90 kPa. - Fixes the issue where air alarms had "danger" status at 20 kPa and "warning" status at 21 kPa --- # Changelog :cl: zelezniciar - fix: Fixes Air Alarms not entering danger/warning state when pressure is low --------- Co-authored-by: VMSolidus <[email protected]>
Reverts #939
We might revert this again if everything burns but it's worth a shot. Let's gooo
Changelog
🆑 Velcroboy