Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass all aquometadata properties to ddl #60

Closed
1 task
veenstrajelmer opened this issue Mar 9, 2024 · 0 comments · Fixed by #88
Closed
1 task

Pass all aquometadata properties to ddl #60

veenstrajelmer opened this issue Mar 9, 2024 · 0 comments · Fixed by #88

Comments

@veenstrajelmer
Copy link
Collaborator

veenstrajelmer commented Mar 9, 2024 •
edited
Loading

  • ddlpy version: main
  • Python version: 3.11
  • Operating System: Windows

Description

When querying the ddl, we only use four aquometadata properties from the location DataFrame:
https://github.com/openearth/ddlpy/blob/80fc95b53883ff7a20b4f8941a38e6945054d586/ddlpy/ddlpy.py#L70-L74

Todo:

  • consider using all .Code properties from the location DataFrame to prevent too much data to be retrieved
This was referenced Mar 11, 2024
Closed
Closed
Closed
@veenstrajelmer veenstrajelmer changed the title Consider passing all aquometadata properties to ddl Pass all aquometadata properties to ddl Mar 27, 2024
@veenstrajelmer veenstrajelmer linked a pull request Mar 27, 2024 that will close this issue
pass all Code keys to measurements request instead of only four #88
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

pass all Code keys to measurements request instead of only four Deltares/ddlpy
1 participant
@veenstrajelmer