Unexpected behaviour in raster.full_from_transform

[roeldegoede]

HydroMT version checks

• I have checked that this issue has not already been reported.
• I have checked that this bug exists on the latest version of HydroMT.

Reproducible Example

According to the documentation of raster.full_from_transform, the shape is defined as "Length along (dim0, x, y) dimensions, of which the first is optional" whereas it returns a DataArray with dimensions y, x (hence flipped).

When calling this function like this, where the mmax is nr of cells in x-direction, and nmax the nr of cells in y-direction, like is done in hydromt.model.processes.grid.create_grid_from_region.

raster.full_from_transform(
        transform,
        shape=(mmax, nmax),
        nodata=1,
        dtype=np.uint8,
        name="mask",
        attrs={},
        crs=geom.crs,
        lazy=False,
    )

Current behaviour

This returns a raster with dimensions mmax by nmax (hence x, y) and not y, x!

Desired behaviour

To properly work, we should change the code into:

raster.full_from_transform(
        transform,
        shape=(nmax, mmax),
        nodata=1,
        dtype=np.uint8,
        name="mask",
        attrs={},
        crs=geom.crs,
        lazy=False,
    )

and change the description of full_from_transform in raster.py

Additional context

No response