setup_rivers does not update river width and depth

[shartgring]

HydroMT-Wflow version checks

• I have checked that this issue has not already been reported.
• I have checked that this bug exists on the latest version of HydroMT-Wflow.

Reproducible Example

Using setup_rivers() to update a model in a Python script does not update all parameter maps. For example, updating river maps with upa=100 to upa=5, resulting in a larger river map, but the wflow_riverwidth and RiverDepth map still only has width values for the cells created by upa=100 and not upa=5

staticmaps.zip

Current behaviour

Does not update river width and depth when upa is changes

Desired behaviour

Update river width and depth for all new river cells, not old ones

Additional context

No response

[shartgring]

Looked into it and think I know what it causing it, will try to fix it myself this week. I think someway in which attribute columns in the gdf are checked and parts in the order/checking of the code are made to work with building models, not updating

[shartgring]

I found what was causing it, also partly an error (typo) from my side. When river_geom_fn is not specified but a model does already contain a river depth and width, the river depth and width maps are not added, so the old width and depth maps remain. What would be desired behaviour, to remove the old width and depth maps when setup_rivers is called.

Or add a width and depth map when river_geom_fn is not specified with the minimum depth and widths? I think this makes sense, and that map then automatically gets the same mask as the river, preventing that these is a mismatch between the number of river cells when a model is updated

[shartgring]

I will close the issue as it is already listed in #195