Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert wflow v0.x toml to v1.0 toml #319

Open
JoostBuitink opened this issue Jan 17, 2025 · 1 comment
Open

Convert wflow v0.x toml to v1.0 toml #319

JoostBuitink opened this issue Jan 17, 2025 · 1 comment
Labels
enhancement New feature or request needs refinement issue still needs refinement
Milestone

Comments

@JoostBuitink
Copy link
Collaborator

Kind of request

Adding new functionality

Enhancement Description

With the new standard names in wflow (Deltares/Wflow.jl#518) for v1.0, the toml will change as well. Besides aligning hydromt_wflow to produce these updated tomls, it should be nice if there is a function that allows automatic conversion of a toml that belongs to wflow v0.x to a toml that can be used for wflow v1.0. We can probably use a mapping dictionary similar to the standard_names.jl script in wflow.

Use case

No response

Additional Context

No response

@JoostBuitink JoostBuitink added enhancement New feature or request needs refinement issue still needs refinement labels Jan 17, 2025
@hboisgon hboisgon added this to the Release 1.0 milestone Feb 25, 2025
@JoostBuitink
Copy link
Collaborator Author

Slightly related to this (and I think we talked about it in the past as well), but would it be an idea to add the hydromt_wflow and targeted wflow version as some [metadata] keys to the toml? This way, we can keep track of where the toml originates from (given that users don't manually change these versions ofcourse :P).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs refinement issue still needs refinement
Projects
None yet
Development

No branches or pull requests

2 participants