Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Masking with subcatch in grid #325

Open
2 tasks done
hboisgon opened this issue Jan 29, 2025 · 0 comments
Open
2 tasks done

Masking with subcatch in grid #325

hboisgon opened this issue Jan 29, 2025 · 0 comments
Labels
bug Something isn't working needs refinement issue still needs refinement
Milestone

Comments

@hboisgon
Copy link
Contributor

HydroMT-Wflow version checks

  • I have checked that this issue has not already been reported.
  • I have checked that this bug exists on the latest version of HydroMT-Wflow.

Reproducible Example

Run the test_model_methods.py::test_setup_lulc_vector and examine the example_wflow_model after calling the setup method.

Current behaviour

Not a real bug but currently masking of variables in grid with the basin boundaries happens in write_grid rather then in the setup_ methods. I think it would be better if it hapened during the set_grid method so that we have a more conform model in python and not only after/when writting.

Desired behaviour

See above.

Additional context

No response

@hboisgon hboisgon added bug Something isn't working needs refinement issue still needs refinement labels Jan 29, 2025
@hboisgon hboisgon added this to the Release 1.0 milestone Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs refinement issue still needs refinement
Projects
None yet
Development

No branches or pull requests

1 participant