Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unittests take too long #1025

Closed
JoerivanEngelen opened this issue May 8, 2024 · 0 comments · Fixed by #1048 · May be fixed by #1029
Closed

Unittests take too long #1025

JoerivanEngelen opened this issue May 8, 2024 · 0 comments · Fixed by #1048 · May be fixed by #1029
Assignees
Labels
performance Execution speed

Comments

@JoerivanEngelen
Copy link
Contributor

JoerivanEngelen commented May 8, 2024

The unittests take too long; locally on my machine ~15 minutes but on TeamCity they approach 45 minutes.

Looking at this example, I observe the following things:

  • imod.tests.test_mf6.test_mf6_regrid_model.test_model_regridding_can_validate and imod.tests.test_mf6.test_mf6_regrid_model.test_model_regridding_can_skip_validation both take nearly 1 minute. These are the longest tests so far in the pipeline
  • There are a lot of tests for splitting and partitioning. We should investigate if we can coarsen grid for these test cases to speed up times.

If this is not doable, we can consider creating a separate pipeline for all the multimodel tests, which can run in parallel.

Alternatively: We can adapt our test strategy and include certain slower tests in a nightly pipeline. In this way changes which break things are not directly identified, but still be traced back to the day of a breaking commit.

@github-project-automation github-project-automation bot moved this to 📯 New in iMOD Suite May 8, 2024
@JoerivanEngelen JoerivanEngelen added the performance Execution speed label May 8, 2024
@JoerivanEngelen JoerivanEngelen self-assigned this May 13, 2024
@JoerivanEngelen JoerivanEngelen moved this from 📯 New to 🏗 In Progress in iMOD Suite May 13, 2024
github-merge-queue bot pushed a commit that referenced this issue May 22, 2024
Fixes #1025

# Description
Test to see if xdist will improve our pipeline build time

# Checklist
<!---
Before requesting review, please go through this checklist:
-->

- [x] Links to correct issue
- [ ] Update changelog, if changes affect users
- [x] PR title starts with ``Issue #nr``, e.g. ``Issue #737``
- [ ] Unit tests were added
- [ ] **If feature added**: Added/extended example
@github-project-automation github-project-automation bot moved this from 🏗 In Progress to ✅ Done in iMOD Suite May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Execution speed
Projects
Status: ✅ Done
1 participant