Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: created fundamentals page ( desktop optimized ) #32

Closed
wants to merge 16 commits into from

Conversation

okhaimie-dev
Copy link
Member

@okhaimie-dev okhaimie-dev commented Oct 27, 2023

Changes

  • Created Fundamentals Page
  • Worked on the responsiveness of page ( This was quite challenging since the Figma designs have no mobile design yet for this page. hence, mobile view still needs a proper design )

====

Steps to review demo env.

  • Click the fundamentals menu item to navigate to page.

Screenshot

CleanShot 2023-10-26 at 22 39 29

#28

@vercel
Copy link

vercel bot commented Oct 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
academy-turbo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 13, 2024 6:44pm
academy-turbo-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 13, 2024 6:44pm

@github-actions
Copy link

github-actions bot commented Oct 27, 2023

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 34
🟢 Accessibility 100
🟢 Best practices 92
🟢 SEO 91
🟢 PWA 100

Lighthouse ran on https://academy-turbo-git-fundamentals-developdao.vercel.app/

@Markkos89
Copy link
Collaborator

gm @okhaimie-dev
can you add any sort of descriptive text to the PR? the screenshot works but you can add plenty of information, notes, comments, things to take a look at, tech debt, info that you needed and is missing already, and maybe more
can you update the title of the PR to be more descriptive? What means Fundamentals only? Take a look at #33 as an example

thanks

apps/academy/src/pages/_app.tsx Outdated Show resolved Hide resolved
apps/academy/src/pages/fundamentals.tsx Outdated Show resolved Hide resolved
@okhaimie-dev okhaimie-dev changed the title Fundamentals feat: created fundamentals page Oct 27, 2023
@okhaimie-dev
Copy link
Member Author

okhaimie-dev commented Oct 27, 2023

gm @okhaimie-dev can you add any sort of descriptive text to the PR? the screenshot works but you can add plenty of information, notes, comments, things to take a look at, tech debt, info that you needed and is missing already, and maybe more can you update the title of the PR to be more descriptive? What means Fundamentals only? Take a look at #33 as an example

thanks

@Markkos89 I renamed the PR title from Fundamentals to feat: created fundamentals page and added more context.

@okhaimie-dev okhaimie-dev changed the title feat: created fundamentals page feat: created fundamentals page ( desktop optimized ) Oct 27, 2023
.vscode/settings.json Outdated Show resolved Hide resolved
@Markkos89
Copy link
Collaborator

Closing this PR as outdated.-

@Markkos89 Markkos89 closed this Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants