Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: home page (desktop) #33

Merged
merged 4 commits into from
Nov 8, 2023
Merged

feat: home page (desktop) #33

merged 4 commits into from
Nov 8, 2023

Conversation

code-z2
Copy link
Contributor

@code-z2 code-z2 commented Oct 27, 2023

created the home page UI.

requires #31

fixes #27

@vercel
Copy link

vercel bot commented Oct 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
academy-turbo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 8, 2023 0:24am
academy-turbo-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 8, 2023 0:24am

@github-actions
Copy link

github-actions bot commented Oct 27, 2023

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 35
🟢 Accessibility 96
🟠 Best practices 75
🟢 SEO 92
🟢 PWA 100

Lighthouse ran on https://academy-turbo-git-feat-home-page-developdao.vercel.app/

Copy link
Collaborator

@Markkos89 Markkos89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peteruche21 there is something wrong because the PR Preview link is looking like the styles didn't loaded:

image

image

image

approving because code-related it's more than good and we can fix anything in another update 😉
manage it at your will

thanks for the hard work my friend!!!! @peteruche21 👑 👑

🧑‍🤝‍🧑

@code-z2
Copy link
Contributor Author

code-z2 commented Oct 27, 2023

I think it is a browser-related issue. it looks okay on my safari.

will switch to another PC and test with Firefox, chrome and Edge browsers later.

edit: doesn't seem like a browser problem. will use another PC to work on this.

@okhaimie-dev
Copy link
Member

okhaimie-dev commented Oct 27, 2023

I think it is a browser-related issue. it looks okay on my safari.

will switch to another PC and test with Firefox, chrome and Edge browsers later.

edit: doesn't seem like a browser problem. will use another PC to work on this.

@peteruche21 I don't think it is a browser specific thing per say, some of the styling from the custom ui library components are missing in the academy app.

You might want to reconfigure the academy repo stylesheet to achieve an improved style on here. e.g. the bttf font file is missing in this repo so even though you are referencing it in the stylesheet, it is technically not possible for it to display properly on development or production preview this way. same goes with some other of the styles

@code-z2
Copy link
Contributor Author

code-z2 commented Oct 27, 2023

Thanks @okhaimie-dev will look at how the styles, but do you think there is a possibility that the academy app specific styles overrides the one from ui package?

@Markkos89

@code-z2
Copy link
Contributor Author

code-z2 commented Oct 27, 2023

I thought initially it was because I referenced styles of ui stylesheet inside academy stylesheet, but some components from ui package are losing styles totally.

@Markkos89
Copy link
Collaborator

Thanks @okhaimie-dev will look at how the styles, but do you think there is a possibility that the academy app specific styles overrides the one from ui package?

@Markkos89

I believe that if you change the order of the styles file import on _app file to:

  • first academy app local styles
  • after ui package styles

it could work, could you try? @peteruche21 thanks mate!!!

@Markkos89
Copy link
Collaborator

@peteruche21 my bad, I merged one PR and it generated a conflict on this one.

Could you pease resolve the conflict, please? Apologize mate 🙏

After that you can move forward to merge this! Thanks for the hard work!!! 💪

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: HomePage Page
3 participants