-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: home page (desktop) #33
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://academy-turbo-git-feat-home-page-developdao.vercel.app/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@peteruche21 there is something wrong because the PR Preview link is looking like the styles didn't loaded:
approving because code-related it's more than good and we can fix anything in another update 😉
manage it at your will
thanks for the hard work my friend!!!! @peteruche21 👑 👑
🧑🤝🧑
I think it is a browser-related issue. it looks okay on my safari. will switch to another PC and test with Firefox, chrome and Edge browsers later. edit: doesn't seem like a browser problem. will use another PC to work on this. |
@peteruche21 I don't think it is a browser specific thing per say, some of the styling from the custom ui library components are missing in the academy app. You might want to reconfigure the |
Thanks @okhaimie-dev will look at how the styles, but do you think there is a possibility that the academy app specific styles overrides the one from ui package? |
I thought initially it was because I referenced styles of ui stylesheet inside academy stylesheet, but some components from ui package are losing styles totally. |
I believe that if you change the order of the styles file import on _app file to:
it could work, could you try? @peteruche21 thanks mate!!! |
@peteruche21 my bad, I merged one PR and it generated a conflict on this one. Could you pease resolve the conflict, please? Apologize mate 🙏 After that you can move forward to merge this! Thanks for the hard work!!! 💪 🚀 |
created the home page UI.
requires #31
fixes #27