Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal. Support v2 #266

Open
drauggres opened this issue Mar 25, 2022 · 4 comments
Open

Proposal. Support v2 #266

drauggres opened this issue Mar 25, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@drauggres
Copy link

drauggres commented Mar 25, 2022

Hi.

I want to suggest creating support branch for adbkit@2.
Version 2 still almost 30 times more popular than v3 (60 times if you also count original adbkit).

The goal is to provide 100% compatible version (with openstf/adbkit) written in TypeScript.

I prepared code in my fork: 5bd7a66...drauggres:master

It contains:

  • my original TypeScript port (after traspilation to JS it should provide exactly the same code stucture and API as coffeescript version)
  • couple bugfixes cherry-picked from v3
  • dependencies updates

UPD:

  • fixed Bluebird imports
  • update @devicefarmer/adbkit-logcat to v2.1.1 (contains TypeScript definitions)

cc: @koral--

@koral-- koral-- added the enhancement New feature or request label Mar 28, 2022
@drauggres
Copy link
Author

drauggres commented Mar 28, 2022

To test this version locally with existing projects:
1. clone my fork or add it as another remote: ~~
~~ * git remote add drauggres https://github.com/drauggres/adbkit.git

~~ * git fetch drauggres~~
~~ * git checkout -b test_ts drauggres/master)~~
2. run npm pack
3. install package in your project (npm install <path_to_devicefarmer-adbkit-VERSION.tgz>)
4. build and test your project

Published as @dead50f7/adbkit (npm install --save @dead50f7/adbkit)

Preferably to test it also with projects written in TypeScript before publishing.

@drauggres
Copy link
Author

cc: @mingyuan-xia

@mingyuan-xia
Copy link

copy

@UrielCh
Copy link

UrielCh commented Apr 6, 2022

@devicefarmer/adbkit should be rolled back to its V2, my V3 change had been merged after I gave up on the merge, and now my V3 is changing quickly; And may switch to a V4 without any V2 code left.

I am now working on some stress tests, with some projects playing android video games using:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants