Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the chosen translation is lost upon refreshing any resource page #15

Open
k-sae opened this issue Mar 13, 2019 · 7 comments
Open

the chosen translation is lost upon refreshing any resource page #15

k-sae opened this issue Mar 13, 2019 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@k-sae
Copy link

k-sae commented Mar 13, 2019

upon changing the language from NovalanguageTool it successfully changes across the dashboard,
however when the page is refreshed, the chosen translation is lost and it is reverted to the default language.
I am not sure if it is a bug in my application, the package or it is intended to work as it is.

steps to reproduce:

  1. change the language from x to y using NovaLanguageTool
  2. Navigate to any resource
  3. refresh the page

Expected result:

  • the dashboard is loaded in language y

Actual result

  • the dashboard is loaded in language x
@mohrajab
Copy link
Contributor

Hi @k-sae , is this issue is still shown for you? please update your version and give me your feedback.

@k-sae
Copy link
Author

k-sae commented Jul 28, 2019

Hi @mohrajab, thank you for responding.
yes, this issue still exists on the latest version, after investigating, I have found that the lang=ar parameter is lost upon navigating to any resource page. in this case, the system has no clue about which local is set upon refreshing.
I had to implement a go-around by sending the chosen local to the back-end, storing it within the session, then set app local according to the stored value using a middleware.
the changes can be found on my forked version: https://github.com/k-sae/multilingual-nova/tree/feat/global-language-changer

@rsiasat00
Copy link

Any updates on this bug? This issue still exists on the latest version.

@NowakAdmin
Copy link

Confirmed - still occurs

@k-sae
Copy link
Author

k-sae commented Dec 19, 2020

@NowakAdmin @rsiasat00
you can use my fork instead, where I am using the session to store language instead of the query parameter. just be sure to configure it probably.

fork link: https://github.com/k-sae/multilingual-nova/tree/feat/global-language-changer

@Fadelwahed Fadelwahed added the bug Something isn't working label Dec 23, 2021
@Fadelwahed
Copy link
Contributor

@mohrajab Can you please solve the problem and close the issue

@Fadelwahed
Copy link
Contributor

@mohrajab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

7 participants