Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser "hung up" when I press "ESC" while dragging mouse to create annotation #535

Closed
kheffah opened this issue Sep 5, 2018 · 5 comments
Labels

Comments

@kheffah
Copy link
Collaborator

kheffah commented Sep 5, 2018

Very often, I would start dragging the mouse to create an annotation, say a rectangle, then I decide I made a mistake and press escape ("esc") to quit it and start a new one. Almost every time I do this, the browser gets completely "hung up", sometimes to the point where I need to close the tab or refresh the page. I don't know what event gets triggered but this is definitely an undesirable behavior. Is this the correct way to stop an annotation midway if you made a mistake?

@kheffah kheffah added the bug label Sep 5, 2018
@jbeezley
Copy link

jbeezley commented Sep 6, 2018

Escape is the right way to do it. I think I found the problem. It will probably only happen when hitting escape while holding down the mouse button. At least in my testing, hitting escape while drawing a rectangle with the "two clicks" method doesn't cause any issues.

@manthey
Copy link
Contributor

manthey commented Sep 6, 2018

I can reproduced that in the GeoJS library (hitting escape while dragging a rectangle), though I had to do it multiple times to cause the browser tab to hang. I'll hunt down the bug there.

@jbeezley
Copy link

jbeezley commented Sep 6, 2018

Ah, okay. I didn't manage to make it occur in the geojs example. I was assuming it had to do with how we retrigger draw mode.

@manthey
Copy link
Contributor

manthey commented Sep 6, 2018

I have a fix for this in OpenGeoscience/geojs#923.

@manthey
Copy link
Contributor

manthey commented Sep 10, 2018

This is fixed in the latest docker builds.

@manthey manthey closed this as completed Sep 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants