Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Google Places] Increase radius to improve location recognition #1

Open
Ti1mmy opened this issue Jan 21, 2022 · 0 comments · May be fixed by #2
Open

[Google Places] Increase radius to improve location recognition #1

Ti1mmy opened this issue Jan 21, 2022 · 0 comments · May be fixed by #2
Assignees
@Ti1mmy
Labels
enhancement New feature or request

Comments

@Ti1mmy
Copy link
Member

Ti1mmy commented Jan 21, 2022

Our radius threshold is set relatively low and typically only works if you are standing right at the centre of a location you plan to shop at.

It would be beneficial to increase this. False positives may increase, but it should be plainly obvious if DisCard is giving you a suggestion for a gas station next door for example.

DisCard/site/js/geolocation.js

Line 46 in dea04b9

radius: 5,

@Ti1mmy Ti1mmy added the enhancement New feature or request label Jan 21, 2022
Ti1mmy added a commit to Ti1mmy/DisCard that referenced this issue Jan 23, 2022
@Ti1mmy
Increase radius threshold to 25m
91860c9 
Resolves DisCardApp#1
@Ti1mmy Ti1mmy linked a pull request Jan 23, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ti1mmy Ti1mmy

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Increase radius threshold to 25m Ti1mmy/DisCard
1 participant
@Ti1mmy