Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for "applied_tags" field for ChannelCreateRequest, ChannelModifyRequest and WebhookExecuteRequest #173

Merged
merged 4 commits into from
Jun 15, 2024

Conversation

Azn9
Copy link
Member

@Azn9 Azn9 commented Jun 11, 2024

@Azn9 Azn9 added the field/addition A field is being added label Jun 11, 2024
@Azn9 Azn9 self-assigned this Jun 11, 2024
@Azn9 Azn9 added this to the 1.6.19 milestone Jun 11, 2024
@Doc94
Copy link
Member

Doc94 commented Jun 11, 2024

Any reason why dont add this in the 1.6.x for make this data available?
also this field can be added in another places like webhooks, and threads (this only in master)

@Azn9
Copy link
Member Author

Azn9 commented Jun 11, 2024

Any reason why dont add this in the 1.6.x for make this data available? also this field can be added in another places like webhooks, and threads (this only in master)

This only applies for forum or media channels, which are not available in 3.2.X

@Doc94
Copy link
Member

Doc94 commented Jun 11, 2024

Any reason why dont add this in the 1.6.x for make this data available? also this field can be added in another places like webhooks, and threads (this only in master)

This only applies for forum or media channels, which are not available in 3.2.X

okay but then this PR can handle all the missing places for that field?

@Azn9
Copy link
Member Author

Azn9 commented Jun 11, 2024

okay but then this PR can handle all the missing places for that field?

Good @Doc94

@Doc94 Doc94 changed the title feat: add support for "applied_tags" field for ChannelCreateRequest and ChannelModifyRequest feat: add support for "applied_tags" field for ChannelCreateRequest, ChannelModifyRequest and WebhookExecuteRequest Jun 11, 2024
@Doc94 Doc94 merged commit d2ddf07 into Discord4J:master Jun 15, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
field/addition A field is being added
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants