Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dedicated Bifrost NPM package to consolidate dependencies #47

Open
ccmcintyre-kingsds opened this issue Jun 17, 2022 · 1 comment
Open
Labels
enhancement New feature or request javascript Relates to JavaScript or Node.js code

Comments

@ccmcintyre-kingsds
Copy link
Contributor

At present, Bifrost introduces various Node.js package dependencies to the directory or project it is initialized in, including calling npm init and generating a package.json, package-lock.json, and node_modules in the working directory as necessary, or adding and installing its dependencies to the existing ones if already present. The exact dependencies, and versions thereof, will vary based on the environment (Node.js version, platform, whether DCP is being used, etc), and the details are not especially transparent to the user. All these decisions and actions are made via npm processes that are started by Bifrost internally during intialization.

As suggested by @wesgarland, a much stronger organizational approach is to have a single explicit js dependency, that points to a NPM module created by us, and which can serve as the consolidated point for coordinating Bifrost's Node.js dependencies, in a way that will be both more clear to the user, and simultaneously less disruptive.

@ccmcintyre-kingsds ccmcintyre-kingsds added enhancement New feature or request javascript Relates to JavaScript or Node.js code labels Jun 17, 2022
@wesgarland
Copy link

Suggested package name: pyjs-bifrost

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request javascript Relates to JavaScript or Node.js code
Projects
None yet
Development

No branches or pull requests

2 participants