Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need external source map support #229

Open
wesgarland opened this issue Jan 31, 2024 · 2 comments
Open

Need external source map support #229

wesgarland opened this issue Jan 31, 2024 · 2 comments

Comments

@wesgarland
Copy link
Collaborator

Describe your feature request here.

Evaluating web pack bundles like dcp-client makes for horrifyingly bad stack traces if we don't have external source map support.

This can be avoided in dcp-client by building a debug bundle which uses internal source maps, but that's not the common case with code found in the wild.

I believe I added an options argument to pm.eval. I suggest adding an option which is the path to the sourcemap file.

Code example

No response

@philippedistributive philippedistributive self-assigned this Feb 13, 2024
@philippedistributive
Copy link
Collaborator

I see
CompileOptions& setSourceMapURL(const char16_t* s)
which looks promising

@wesgarland
Copy link
Collaborator Author

This might not be possible in spidermonkey

External source map support seems limited to passing a URL through from JS::Compile to the script object, where in firefox it is extracted JS debugger, and parsed in userland (I think)

A quick experiment,

   options.setSourceMapURL(u"file://./dcp-client-bundle.js.map");

also doesn't seem to do anything, I even looked with strace and tried a few variations.

We may have to punt on this one.

@philippedistributive philippedistributive removed their assignment Mar 15, 2024
@philippedistributive philippedistributive closed this as not planned Won't fix, can't repro, duplicate, stale Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

2 participants