Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

making it easier for people to contribute via documentation and todo in code #90

Open
coolharsh55 opened this issue Oct 8, 2015 · 5 comments

Comments

@coolharsh55
Copy link
Contributor

It can be difficult to dive in and start developing a feature by oneself. Instead, we can put in comments indicating places of interest where people can add functionality or improve existing features. Something like this:

def foo(*args, **kwargs):
    # does things x, y, and z
    # ...
    # todo: add assertions for arguments
    return x, y, z

This will allow a general search for todo in github to show places of interest where everybody can contribute to. Things like assertions, validations, refactoring, enhancements, and other things major and minor can be added in code via helpful comments. This way, everything does not need to be attached to an issue, only things that require discussions or are major features, or require management can be managed by issues. Using todo in documentation will also encourage people to peep into the code rather than just talk over slack or dig through the issues.

@Heasummn
Copy link
Contributor

I think we should use a documentation generator. I loved the concept of JavaDocs in Java. Sphinx would be my choice for something of this in Python.

@SanketDG
Copy link
Member

@Heasummn I think mkdocs makes more sense here. Sphinx is not easy to get started with IMHO.

@Heasummn
Copy link
Contributor

@SanketDG You're right, mkdocs seems much simpler, though I've done Sphinx before and that causes bias in me.

@nitinpaultifr
Copy link

Documentation apart, I like the idea of adding 'TODOs' in the code so that people can look them up and do simple stuff, instead of tackling issues and bugs if they don't want to

@SanketDG
Copy link
Member

I have been thinking and I dont think a separate documentation would be needed. We have the wiki, which frankly is hidden, so we need it linked in the right places.

And then, with the combination of docstrings and inline comments, docs seem redundant.

Do we still need one @Heasummn @npaul2811 @coolharsh55 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants