Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sendMail Hook in CMailFile class sendfile() can't trigger error #31833

Closed
dev2info opened this issue Nov 15, 2024 · 3 comments
Closed

sendMail Hook in CMailFile class sendfile() can't trigger error #31833

dev2info opened this issue Nov 15, 2024 · 3 comments
Labels
Bug This is a bug (something does not work as expected) Event: Devcamp 2024 Nancy

Comments

@dev2info
Copy link

Bug

sendfile() method in CMailFile class returns true or false so returning -1 via sendMail Hook do not trigger any error

Dolibarr Version

18.0.5

Environment PHP

7.3.27

Environment Database

sql

Steps to reproduce the behavior and expected behavior

No response

Attached files

No response

@dev2info dev2info added the Bug This is a bug (something does not work as expected) label Nov 15, 2024
@marc-dll
Copy link
Contributor

Hello,

Thank you for you contribution.

This issue has already been fixed in Dolibarr version 20.0.

Greetings.

@bafbes
Copy link
Contributor

bafbes commented Nov 15, 2024

Why do you need to return -1 ?

@kkhelifa-opendsi
Copy link
Contributor

It's fixed in develop
PR in progress #31460

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This is a bug (something does not work as expected) Event: Devcamp 2024 Nancy
Projects
None yet
Development

No branches or pull requests

5 participants