Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #30766 Extra field Can Always Be Edited #31876

Merged
merged 7 commits into from
Nov 20, 2024
Merged

Fix #30766 Extra field Can Always Be Edited #31876

merged 7 commits into from
Nov 20, 2024

Conversation

Daoud-mohamed
Copy link
Contributor

Fix #30766 Extra field Can Always Be Edited

#30766

@eldy eldy added the PR to fix - See feedback in comments PR needs to be fixed to be integrated (some comments should describes the fix to do) label Nov 16, 2024
@eldy
Copy link
Member

eldy commented Nov 16, 2024

Must use object $object instead of id.

@Daoud-mohamed
Copy link
Contributor Author

Must use object $object instead of id.
@eldy Done!

@eldy eldy merged commit f71bb45 into Dolibarr:develop Nov 20, 2024
6 checks passed
eldy pushed a commit that referenced this pull request Nov 20, 2024
@Daoud-mohamed @eldy
Fix #30766 Extra field Can Always Be Edited (#31876)
914ed1b 
* fix alwayseditable

* Update extrafields.class.php

* Update extrafields.class.php

* Update extrafields.class.php

* enhance fix alwayseditable

* fix phan
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Event: Devcamp 2024 Nancy PR to fix - See feedback in comments PR needs to be fixed to be integrated (some comments should describes the fix to do)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extra field “Can Always Be Edited” Setting Not Working as Expected
2 participants
@Daoud-mohamed @eldy