TakePOS: Fix bug when attempting to pay a credit note invoice

[NextGestion]

TakePOS: Fix bug when attempting to pay a credit note invoice

[NextGestion]

Hello @eldy,

Can you check this PR #32233 , and see if it can be merged?

Thank you

[eldy]

Hello @eldy,

Can you check this PR #32233 , and see if it can be merged?

Thank you

Can you describe the use case. How do you get a credit note invoice in the POS ? It seems you can only generate standard invoice. What steps do you do ?

[NextGestion]

Hello @eldy ,

Please follow the steps below :

• In TakePOS, pay a standard invoice
• Click the "Create credit note" button
  

htdocs/takepos/invoice.php :

• Attempt to pay the credit note invoice
• You will face the issue below :
  

[eldy]

I see, it seems this implementation of credit note in takepos is not yet complete. When we go on the button "Pay", we still have label "received" when we should have refund. A lot of this are still wrong.
For the fix you suggest, i suggest instead to make 1 common test using abs to use 2 different tests depending on type of invoice so we keep the protection to avoid to pay a standard invoice if amount is negative.

So
if $invoice->getRemainToPay() > 0) {
become

if (($invoice->getRemainToPay() > 0 && $invoice->type == Facture::TYPE_STANDARD)
||($invoice->getRemainToPay() < 0 && $invoice->type == Facture::TYPE_CREDITNOTE))  {

of your PR,