Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding isOwnerOf interface #7

Open
estarriolvetch opened this issue Dec 5, 2022 · 0 comments
Open

Adding isOwnerOf interface #7

estarriolvetch opened this issue Dec 5, 2022 · 0 comments

Comments

@estarriolvetch
Copy link

estarriolvetch commented Dec 5, 2022

Hi @DonkeVerse @jeffreyscholz

I am building two ERC1155 NFT implementations that also restricts themselves for 1/1 NFTs applications, and I am wondering whether we can have a common interface that can potentially be a standard in the future.

Since the implementation of ERC1155Delta doesn't allow querying the ownership information from the id in order to achieve constant-gas batch minting. Therefore, ownerOfERC721Like will not work in this implementation.

Instead, I am proposing to use the following interface for the ownership verification purpose.

 function isOwnerOf(address account, uint256 id) external view returns(bool);

Also, adding this interface to supportsInterface so the third-party contract can recognise it and enables applications that is only available to 1/1 NFTs.

@estarriolvetch estarriolvetch changed the title isOwnerOf Adding isOwnerOf interface Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant