Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait a minute, what if I didn't extract manifests and instead just directly read them from the zip file like FenPhoenix does with AngelLoader? #175

Open
DrewNaylor opened this issue Sep 10, 2023 · 0 comments
Labels
enhancement New feature or request
Milestone

Comments

@DrewNaylor
Copy link
Owner

DrewNaylor commented Sep 10, 2023

That should help with performance and save disk writes. Hopefully it's not too difficult to grab specific files from the zip file like it is with another format I think that Fen complained about in one video from a while ago.

This way I can still have stuff like the code where I find the path for the details/locale manifest from the version manifest, for example.

Edit: I can also delete the un-necessary stuff from the zip file before moving it to the correct location, and I can use GetEntry to just read specific files.

@DrewNaylor DrewNaylor added this to the Version 0.5 milestone Sep 10, 2023
@DrewNaylor DrewNaylor added the enhancement New feature or request label Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant