-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QueryBuilder missing AppendLine( FormattableString ) #9
Comments
How did it go? I think both 2 and 3 are good options. Previously methods were just named "Append/AppendLine" (and would always take a FormattableString) but since I've introduced |
OK. If by design, will use method 3. Compiles, writing some integration tests to my project so I can run/confirm nothing changes in results :) Will let you know. |
@terryaney Did it work? Can we close this? |
Pulled away, but actually was just working on finishing all my integration tests. You can close this and I'll reopen if the issue presents itself? |
Yes it worked :) |
Could be by design and that is fine, but in DapperQueryBuilder, I could do:
However, I get
Argument 1: cannot convert from 'System.FormattableString' to 'InterpolatedSql.IInterpolatedSql'
in InterpolatedSql. I've found a few workarounds so maybe that is intention. Let me know if method was missed or if I one of the workarounds below is the desired pattern going forward:Workaround 1 - no Ternary operator
Workaround 2 - Found this method I've never used before
Workaround 3 - Appending via += seems to compile
I'm going to test with number 3, but please advise. Thanks.
The text was updated successfully, but these errors were encountered: