Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DesignSPHysics] Please create a SVG logo for this workbench #14

Closed
luzpaz opened this issue Jun 14, 2019 · 10 comments · Fixed by FreeCAD/FreeCAD#2623
Closed

[DesignSPHysics] Please create a SVG logo for this workbench #14

luzpaz opened this issue Jun 14, 2019 · 10 comments · Fixed by FreeCAD/FreeCAD#2623

Comments

@luzpaz
Copy link
Contributor

luzpaz commented Jun 14, 2019

This will be needed to the newly improved Addon Manager FreeCAD/FreeCAD-addons#37

@luzpaz
Copy link
Contributor Author

luzpaz commented Jun 17, 2019

@LoreDocasar ping

@zlotny
Copy link
Collaborator

zlotny commented Jul 1, 2019

Hi there! Currently we don't have people in here that know how to do vector art, so for now we can't provide a logo for the addon manager. I'll try to work on a logo rework that could be easily vectorized soon.

I'll keep this open until we can look at this a bit further, sorry about that.

@luzpaz
Copy link
Contributor Author

luzpaz commented Jul 1, 2019

@zlotny we can post a request to FreeCAD subforum and they may do it for you?

Edit: https://forum.freecadweb.org/viewforum.php?f=34

@zlotny
Copy link
Collaborator

zlotny commented Jul 1, 2019

That's a possibility. I'll talk tomorrow with the team in here to check if they want to do that as it is kind of a style decision.

I'll make a post if we decide to try to work with people wanting to contribute. Thanks for the suggestion!

@luzpaz
Copy link
Contributor Author

luzpaz commented Aug 8, 2019

bump

@luzpaz
Copy link
Contributor Author

luzpaz commented Aug 27, 2019

sorry, don't mean to seem impatient, just wondering if there is a consensus about this but it wasn't posted to this ticket yet?

@luzpaz
Copy link
Contributor Author

luzpaz commented Sep 4, 2019

Currently this is hwo DesignSPHysics looks like in the Addon Manager:
image

@zlotny
Copy link
Collaborator

zlotny commented Sep 6, 2019

Hi there, don't work on august as the most part of the team is on vacation, so hence the delay.

I made the logo myself. It's probably not perfect as I learned to use Inkscape like a few days ago, but this could suffy. Also I'm planning to replace the current icons on the application with vector files so it scales better.

I attach to you here the minified svg insize a zip.
designsphysics-minified.zip

luzpaz added a commit to luzpaz/FreeCAD that referenced this issue Oct 15, 2019
luzpaz added a commit to luzpaz/FreeCAD that referenced this issue Oct 16, 2019
Closes DualSPHysics/DesignSPHysics#14 
Note: Swapped out logo from upstream with one that we've modified downstream. Forum thread: https://forum.freecadweb.org/viewtopic.php?f=34&t=40136
luzpaz added a commit to luzpaz/FreeCAD that referenced this issue Oct 16, 2019
Closes DualSPHysics/DesignSPHysics#14 
Note: Swapped out logo from upstream with one that we've modified downstream. Forum thread: https://forum.freecadweb.org/viewtopic.php?f=34&t=40136
yorikvanhavre pushed a commit to FreeCAD/FreeCAD that referenced this issue Oct 17, 2019
Closes DualSPHysics/DesignSPHysics#14 
Note: Swapped out logo from upstream with one that we've modified downstream. Forum thread: https://forum.freecadweb.org/viewtopic.php?f=34&t=40136
@luzpaz
Copy link
Contributor Author

luzpaz commented Oct 17, 2019

Hey @zlotny just a heads up that we've merged the SVG in to the Addon Manager with a caveat, we altered it (documented in FreeCAD/FreeCAD#2623) because the icon was far too large and detailed for the Addon Manager UI. If you have an issue with this please make a PR to FreeCAD master. Thanks!

@luzpaz luzpaz closed this as completed Oct 17, 2019
@zlotny
Copy link
Collaborator

zlotny commented Oct 18, 2019

Couldn't check this earlier as I was pretty busy these days. The logo is fine. The one I did includes a raster that makes the final file pretty large, it seems.

However for a small icon inside the AddonManager that would do fine.

Thanks for your work and to the user vocx for adapting the SVG.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants