From f47f08b696c34ed027dbdb5fd22f18abb08fbd51 Mon Sep 17 00:00:00 2001
From: khalidabuhakmeh <khalidabuhakmeh@gmail.com>
Date: Wed, 29 Jan 2025 12:04:54 -0500
Subject: [PATCH 1/3] Update links and add alt attribute in Index page

Replaced static href attributes with ASP.NET tag helpers for links to accurately generate links.
---
 bff/samples/IdentityServer/Pages/Index.cshtml | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/bff/samples/IdentityServer/Pages/Index.cshtml b/bff/samples/IdentityServer/Pages/Index.cshtml
index 440a8fc60..1325c4ba6 100644
--- a/bff/samples/IdentityServer/Pages/Index.cshtml
+++ b/bff/samples/IdentityServer/Pages/Index.cshtml
@@ -3,7 +3,7 @@
 
 <div class="welcome-page">
     <h1>
-        <img src="~/duende-logo.svg" class="logo">
+        <img alt="Duende Logo" src="~/duende-logo.svg" class="logo">
         Welcome to Duende IdentityServer
         <small class="text-muted">(version @Model.Version)</small>
     </h1>
@@ -11,17 +11,17 @@
     <ul>
         <li>
             IdentityServer publishes a
-            <a href="~/.well-known/openid-configuration">discovery document</a>
+            <a href="@Url.Content("~/.well-known/openid-configuration")">discovery document</a>
             where you can find metadata and links to all the endpoints, key material, etc.
         </li>
         <li>
-            Click <a href="~/diagnostics">here</a> to see the claims for your current session.
+            Click <a asp-page="/Diagnostics/Index">here</a> to see the claims for your current session.
         </li>
         <li>
-            Click <a href="~/grants">here</a> to manage your stored grants.
+            Click <a asp-page="/Grants/Index">here</a> to manage your stored grants.
         </li>
         <li>
-            Click <a href="~/ciba/all">here</a> to view your pending CIBA login requests.
+            Click <a asp-page="/Ciba/All">here</a> to view your pending CIBA login requests.
         </li>
         <li>
             Here are links to the

From 760fd95563b1c534abb6502636056702c106566f Mon Sep 17 00:00:00 2001
From: khalidabuhakmeh <khalidabuhakmeh@gmail.com>
Date: Thu, 30 Jan 2025 08:25:05 -0500
Subject: [PATCH 2/3] fix nullability issue in BFF project

---
 bff/test/Duende.Bff.Tests/TestFramework/TestLoggerProvider.cs | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/bff/test/Duende.Bff.Tests/TestFramework/TestLoggerProvider.cs b/bff/test/Duende.Bff.Tests/TestFramework/TestLoggerProvider.cs
index 8538f1ef3..d44412d06 100644
--- a/bff/test/Duende.Bff.Tests/TestFramework/TestLoggerProvider.cs
+++ b/bff/test/Duende.Bff.Tests/TestFramework/TestLoggerProvider.cs
@@ -1,6 +1,8 @@
 // Copyright (c) Duende Software. All rights reserved.
 // See LICENSE in the project root for license information.
 
+#nullable enable
+
 using Microsoft.Extensions.Logging;
 using System;
 using System.Collections.Generic;

From 7addafbaa63ea1dc158527cf66fe0eb79e3327f7 Mon Sep 17 00:00:00 2001
From: khalidabuhakmeh <khalidabuhakmeh@gmail.com>
Date: Thu, 30 Jan 2025 08:35:13 -0500
Subject: [PATCH 3/3] changed TestLoggerProvider to avoid null constructor
 parameters

---
 .../TestFramework/TestLoggerProvider.cs               | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/bff/test/Duende.Bff.Tests/TestFramework/TestLoggerProvider.cs b/bff/test/Duende.Bff.Tests/TestFramework/TestLoggerProvider.cs
index d44412d06..8d6210996 100644
--- a/bff/test/Duende.Bff.Tests/TestFramework/TestLoggerProvider.cs
+++ b/bff/test/Duende.Bff.Tests/TestFramework/TestLoggerProvider.cs
@@ -1,16 +1,17 @@
 // Copyright (c) Duende Software. All rights reserved.
 // See LICENSE in the project root for license information.
 
-#nullable enable
-
 using Microsoft.Extensions.Logging;
 using System;
 using System.Collections.Generic;
 
 namespace Duende.Bff.Tests.TestFramework
 {
-    public class TestLoggerProvider(WriteTestOutput? writeOutput = null, string? name = null) : ILoggerProvider
+    public class TestLoggerProvider(WriteTestOutput writeOutput, string name) : ILoggerProvider
     {
+        private readonly WriteTestOutput _writeOutput = writeOutput ?? throw new ArgumentNullException(nameof(writeOutput));
+        private readonly string _name = name ?? throw new ArgumentNullException(nameof(name));
+
         public class DebugLogger : ILogger, IDisposable
         {
             private readonly TestLoggerProvider _parent;
@@ -43,11 +44,11 @@ public void Log<TState>(LogLevel logLevel, EventId eventId, TState state, Except
             }
         }
 
-        public List<string> LogEntries = new List<string>();
+        public List<string> LogEntries { get; } = new();
 
         private void Log(string msg)
         {
-            writeOutput?.Invoke(name + msg);
+            _writeOutput?.Invoke(_name + msg);
             LogEntries.Add(msg);
         }