Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An invalid entry in .linkconfig prevents Link from establishing a Link, but it does not add "Error" to the message #655

Open
aplteam opened this issue Jun 18, 2024 · 1 comment
Labels
bug Something isn't working MID Should be done fairly soon

Comments

@aplteam
Copy link
Contributor

aplteam commented Jun 18, 2024

The only way to establish whether Link encountered a problem is to do a text analysis of the result. So far, it appeared that I could rely on looking for the string "ERRORS ENCOUNTERED" in the result returned by Link's Create function, but that is not quite true.

I got <Unknown Debug options in "/path/2/.linkconfig": NOTIFY> despite the fact that no Link was established.

It should use "ERRORS ENCOUNTERED". Even better would be the return of proper numeric return codes indicating success (0) or failure (any positive integer).

To Reproduce

I accidentally hat a file .linkconfig that reads:

{
  LinkVersion: { ID: "4.0.17"},

  Settings: {    
  },
  Debug: {
	NOTIFY: 1,
  },
}

That stops Cider from working properly.

I am on:

Dyalog  19.0.49376 64-bit Unicode, BuildID 384d265e 
 OS      Windows 11 (10.0.22631) 64-bit              
 Link    4.0.17                                      
 SALT    2.915                                       
 UCMD    2.6                                         
 .NET    .NET Framework 4.8.9241.0                   
 WS      19.0                                        
 Tatin   0.108.2-beta-3                              
 Cider   0.40.1                                      
@aplteam aplteam added the bug Something isn't working label Jun 18, 2024
@abrudz abrudz added the low Needs doing, but isn't urgent label Dec 16, 2024
@aplteam
Copy link
Contributor Author

aplteam commented Dec 22, 2024

I object to ranking this as low. To this day, the only way to find out whether a command was executed successfully is by analyzing the message returned; Link neither throws an error nor gives back a return code. That's why having "Error" within the message returned is essential.

@abrudz abrudz added MID Should be done fairly soon and removed low Needs doing, but isn't urgent labels Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working MID Should be done fairly soon
Projects
None yet
Development

No branches or pull requests

2 participants