Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing track resets the volume #147

Open
ranile opened this issue Nov 22, 2024 · 1 comment
Open

Changing track resets the volume #147

ranile opened this issue Nov 22, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@ranile
Copy link

ranile commented Nov 22, 2024

Describe the bug
Loading a track resets the volume set previously

This is almost certainly due to howl instance being recreated on load:

const load = useCallback((...[src, options = {}]: LoadArguments) => {
// the HowlInstanceManager will intercept this newly created howl and broadcast it to registered hooks
howlManager.current.createHowl({
src,
...options
})
}, [])

public createHowl(options: { src: string } & AudioLoadOptions) {
this.destroyHowl()

Reusing the same howl instance, or at least copying over the settings from current one over should resolve this

To Reproduce
With global audio player

  1. load a track
  2. setVolume (anything other than 100%)
  3. load another track
  4. Volume is back to 100%

Expected behavior
Volume should stay

Environment (please complete the following information):

  • Browser/ browser version: Firefox 132.0.2
  • Library version: 2.2.0
  • React version: 18.2.0
  • Node version: 18
@E-Kuerschner E-Kuerschner added the bug Something isn't working label Dec 20, 2024
@E-Kuerschner
Copy link
Owner

Hi @ranile, thank you for the issue. I have some time coming up dedicated to this project so I will see about getting this in. Planning for some maintenance work on the repo as well as some bug fixes.

@E-Kuerschner E-Kuerschner added this to the Holiday 2024 Work milestone Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants