Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat] 둘러보기 모드에서 토큰이 필요한 작업이 요청될시 바텀 모달을 띄우도록 설계 #90

Open
CJiu01 opened this issue Sep 21, 2024 · 4 comments
Open

[Feat] 둘러보기 모드에서 토큰이 필요한 작업이 요청될시 바텀 모달을 띄우도록 설계 #90

CJiu01 opened this issue Sep 21, 2024 · 4 comments
Assignees
@CJiu01
Labels
🛠️ Fix 🚨 HotFix
Milestone
2.2.0

Comments

@CJiu01
Copy link
Collaborator

CJiu01 commented Sep 21, 2024 •
edited by HI-JIN2
Loading

📲 Feature Request

💡 세부업무

해야 할 업무에 대해서 설명해주세요!

둘러보기 모드에서 토큰이 필요한 작업이 요청될시 바텀 모달을 띄우도록 설계

📝 ETC

현재는 로그인 화면으로 돌아가게 설정되어있는데, UX를 해치는 것 같아, 바텀 모달에서 로그인 처리하고 이전에 요청하던 작업으로 이어질 수 있게 해주세요.

image
@CJiu01 CJiu01 added this to the 2.2.0 milestone Sep 21, 2024
@CJiu01 CJiu01 self-assigned this Oct 16, 2024
@CJiu01 CJiu01 modified the milestones: 2.2.0, 2.1.5 Oct 16, 2024
@CJiu01
Copy link
Collaborator Author

CJiu01 commented Oct 18, 2024

해당 부분은 적용되어 있어 이슈 닫겠습니다.

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2024-10-18.at.16.48.34.mp4

@CJiu01 CJiu01 closed this as completed Oct 18, 2024
@HI-JIN2
Copy link
Member

HI-JIN2 commented Oct 18, 2024 •
edited
Loading

아니요! Alert 아니고 저희 피그마에 있는 바텀 모달 나와야해요! 로그인 화면으로 안돌아가요! @CJiu01

image

@HI-JIN2 HI-JIN2 reopened this Oct 18, 2024
@CJiu01 CJiu01 modified the milestones: 2.1.5, 2.2.0 Oct 22, 2024
@HI-JIN2 HI-JIN2 mentioned this issue Nov 11, 2024
Open
@HI-JIN2
Copy link
Member

HI-JIN2 commented Nov 18, 2024

🧰 Fix Request

📝 설명

할 일을 적어주세요.

  • 지효님께서 남겨주신 고쳐야 할 사항입니다.
  • [둘러보기 리뷰페이지] 로그인 바텀시트 처리

🗂️ 첨부자료

  • 자료를 첨부해주세요.

@HI-JIN2 HI-JIN2 changed the title [Feat] 둘러보기->리뷰작성 시, Alert 띄우기 [Feat] 둘러보기 모드에서 토큰이 필요한 작업이 요청될시 바텀 모달을 띄우도록 설계 Nov 18, 2024
@CJiu01
Copy link
Collaborator Author

CJiu01 commented Nov 26, 2024

  • 최소 버전 iOS 16+
  • sheet.detents = .custom
  • os에 따른 레이아웃 조정

CJiu01 added a commit that referenced this issue Nov 28, 2024
@CJiu01
[#90] LoginPromptVC 구현
43e671e
CJiu01 added a commit that referenced this issue Nov 28, 2024
@CJiu01
[#90] LoginView 컨벤션 적용
bd04b70
CJiu01 added a commit that referenced this issue Nov 28, 2024
@CJiu01
[#90] RestaurantTableViewHeader MARK 주석 추가
5c513cc
CJiu01 added a commit that referenced this issue Nov 28, 2024
@CJiu01
[#90] RestaurantTableViewHeader MARK 주석 수정
bc07ecd
CJiu01 added a commit that referenced this issue Nov 28, 2024
@CJiu01
[#90] 함수 접근지정자 추가
10890c2
CJiu01 added a commit that referenced this issue Nov 28, 2024
@CJiu01
[#90] LoginPromptVC 코드 구조 통일 작업
252a5c5
CJiu01 added a commit that referenced this issue Nov 28, 2024
@CJiu01
[#90] 모달 레이아웃 os 대응 완료(color 속성 o)
3f8655d
CJiu01 added a commit that referenced this issue Nov 28, 2024
@CJiu01
[#90] 모달 color 속성 제거 및 정렬
7f2419e
CJiu01 added a commit that referenced this issue Nov 28, 2024
@CJiu01
[#90] 코드 정리
4ee0f6a
@CJiu01 CJiu01 mentioned this issue Nov 28, 2024
Merged
CJiu01 added a commit that referenced this issue Nov 28, 2024
@CJiu01
Merge pull request #184 from EAT-SSU/fix/#90
b5e1a5a 
[#90] `16+`의 모달 Sheet UI 작업 완료
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CJiu01 CJiu01

Labels
🛠️ Fix 🚨 HotFix
Projects
None yet
Milestone
2.2.0
Development

No branches or pull requests
2 participants
@HI-JIN2 @CJiu01