Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some backfits are poorly aligned in plotting #34

Open
judgemt opened this issue Oct 27, 2023 · 4 comments
Open

some backfits are poorly aligned in plotting #34

judgemt opened this issue Oct 27, 2023 · 4 comments

Comments

@judgemt
Copy link
Collaborator

judgemt commented Oct 27, 2023

error appears to be sporadic and not common, but noticable when zooming in. Strangely, the intensities of these fits appear correct, but they appear shifted.

@judgemt
Copy link
Collaborator Author

judgemt commented Nov 28, 2023

this was because the fit optimization result was not used to set spec.start and spec.end in backfit_rfs3(). This should now be fixed.

@judgemt
Copy link
Collaborator Author

judgemt commented Nov 28, 2023

lags did not match the fits

@judgemt
Copy link
Collaborator Author

judgemt commented Nov 28, 2023

e.g. we were supposed to get this:
image
but instead would get something like this:
image

@judgemt judgemt mentioned this issue Nov 28, 2023
@judgemt
Copy link
Collaborator Author

judgemt commented Mar 1, 2024

Just tested specific problematic fits again by re-running backfit_rfs3(), and the issue appears to be resolved. It is not in the fit reconstruction or plotting functions, nor does it have anything to do with matching (for these examples). see troubleshooting_fits.R push from today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant