Rest API V2.0 - Technical Testing Feedback

[sprintell]

• Problem of All endpoints produces JSON containing embedded collection names as classNameList format.

• This should be fixed by customizing the collection names using @relation and @collectionRelation annotation on on all the Data Transfer Objects

• Problem of all the endpoints renders _links before payload content.

• This should be fixed by specifying the order using the @JsonPropertyOrder on all the Data Transfer Objects

• Rest API keys should be consistent all through, some are in camelCase while some are in snake case, we should probably just maintain snake case all through

• URLs pattern should be consistent as well, some are in kebab case while some are in camel case, we should probably just maintain kebab case all through

• A link should exist between SNPs and GenomicController

• Authors should not be embedded in publication be a separate endpoint linked to Publications

• /gwas/rest/api/v2/associations/163449091/loci endpoint has some mapping error hence not displaying standard JSON payload

• url parameters must be snake case not camelcase - efoTrait in association endpoint and other places

• Global Exception handlers are not added. exception yet to be properly handled across all endpoints e.g http://gwas-snoopy:8087/gwas/rest/api/v2/studies/GCST90297764678