Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about generative model notebook #123

Open
hyunwoongko opened this issue Aug 9, 2022 · 1 comment
Open

Question about generative model notebook #123

hyunwoongko opened this issue Aug 9, 2022 · 1 comment

Comments

@hyunwoongko
Copy link

https://github.com/ELS-RD/transformer-deploy/blob/main/demo/generative-model/gpt2.ipynb

In this notebook, when you tested cache feature, I think you should use generate function rather than forward function because the advantages of cache can be obtained with saving past generated tensors. but if we use forward function there are no past tensors. Please let me know if I was wrong.

@pommedeterresautee
Copy link
Member

I would check the T5 notebook for the caching feature with generative models.
GPT2 one needs some rework on that topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants