Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Our Fork #18

Open
Querela opened this issue Jun 12, 2024 · 1 comment
Open

Our Fork #18

Querela opened this issue Jun 12, 2024 · 1 comment

Comments

@Querela
Copy link

Querela commented Jun 12, 2024

Hi,

thank you for your public repo. We used this in our fork with some additional changes.
And after some cleanup and reorganizing we now finally have made it public. Yay.

What could be of interest to you is how we decided to add changes to the noske source files. It was mostly necessary since we had too many modifications to apply them with sed etc. in the Dockerfile. Our approach is to store our changes in a kind of overlay folder, so on build we extract the original source files and then overwrite specific files with our changes. Upgrading versions requires us to check for changes but this is mostly true when using sed, too, even if a bit more effort.

We also added some primitive method to scope corpora by user (when using auth) but this is something we are still working on to make more robust...

Lots of modifications are also just for our setup, so are probably not too relevant to you.

@dlazesz
Copy link
Member

dlazesz commented Jun 25, 2024

Thank you for your feedback!

We certainly will check your repo and evaluate what changes we will apply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants