Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ctsm5.3.022: Update FATES namelist and build options to avoid Meier2022 #2934

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

ctsm5.3.022: Update FATES namelist and build options to avoid Meier2022 #2934

wants to merge 8 commits into from

Conversation

glemieux
Copy link
Collaborator

@glemieux glemieux commented Jan 14, 2025 •
edited by ekluzek
Loading

Description of changes

Avoid running fates with z0param_method=Meier2022 in light of #2932.

Specific notes

Contributors other than yourself, if any:

CTSM Issues Fixed (include github issue #):
Does the first step in #2932

Are answers expected to change (and if so in what way)? Yes, for fates compsets with Clm60

Any User Interface Changes (namelist or namelist defaults changes)? Yes, changes default for roughness for FATES and disallows one option when FATES is used

Does this create a need to change or add documentation? Did you do so? No

Testing performed, if any: will do regular and fates tests suites

@glemieux glemieux requested a review from ekluzek January 14, 2025 19:39
@glemieux glemieux mentioned this pull request Jan 14, 2025
Open
5 tasks
@ekluzek ekluzek added enhancement new capability or improved behavior of existing capability priority: high High priority to fix/merge soon, e.g., because it is a problem in important configurations FATES A change needed for FATES that doesn't require a FATES API update. science Enhancement to or bug impacting science non-bfb Changes answers (incl. adding tests) size: small test: aux_clm Pass aux_clm suite before merging test: fates Pass fates test suite before merging labels Jan 14, 2025
@ekluzek ekluzek added this to the cesm3_0_beta06 milestone Jan 14, 2025
ekluzek
ekluzek requested changes Jan 14, 2025
View reviewed changes
Copy link
Collaborator

@ekluzek ekluzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @glemieux and getting this in quickly. We'll talk Thursday on where this should go in upcoming tags.

I ask for a couple changes that are easy.

bld/CLMBuildNamelist.pm Outdated Show resolved Hide resolved
@glemieux glemieux linked an issue Jan 15, 2025 that may be closed by this pull request
'Meier 2022' z0 parameterization causes errors with FATES (especially in SP mode.) #2932
Open
5 tasks
This was referenced Jan 15, 2025
Open
Open
@ekluzek ekluzek changed the title Update FATES namelist and build options to avoid Meier2022 ctsm5.3.022: Update FATES namelist and build options to avoid Meier2022 Jan 16, 2025
@glemieux
Copy link
Collaborator Author

Regression testing on derecho is underway.

@glemieux
Copy link
Collaborator Author

glemieux commented Jan 23, 2025 •
edited
Loading

aux_clm testing against ctsm5.3.020 baseline are showing DIFFs only in tests with Clm60 in the compsets as expected.

Results: /glade/u/home/glemieux/scratch/ctsm-tests/tests_pr2934-aux_clm

Waiting on izumi to come back up.

@glemieux
Copy link
Collaborator Author

glemieux commented Jan 27, 2025 •
edited
Loading

@ekluzek what do you think about me bringing in #2936 with this PR? It would create more FATES diffs since we'd need to update the fates tag in .gitmodules for the fates-side PR associated with #2936 (NGEET/fates#1273). But both the ctsm-side changes are pretty minimal and ctsm tests would still be b4b.

Also, if that sounds ok, we could include #2898 as well.

@ekluzek
Copy link
Collaborator

ekluzek commented Jan 27, 2025

Perfectly fine @glemieux and up to you. Since this is a tag on master there is no need to make it b4b. So do what you need to do.

@glemieux glemieux mentioned this pull request Jan 28, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekluzek ekluzek ekluzek requested changes

@rgknox rgknox rgknox left review comments

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
enhancement new capability or improved behavior of existing capability FATES A change needed for FATES that doesn't require a FATES API update. non-bfb Changes answers (incl. adding tests) priority: high High priority to fix/merge soon, e.g., because it is a problem in important configurations science Enhancement to or bug impacting science size: small test: aux_clm Pass aux_clm suite before merging test: fates Pass fates test suite before merging
Projects
CTSM: Upcoming tags
Status: In progress - master/b4b-dev
Milestone
cesm3_0_beta06
Development

Successfully merging this pull request may close these issues.

'Meier 2022' z0 parameterization causes errors with FATES (especially in SP mode.)
3 participants
@glemieux @ekluzek @rgknox