Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependence of Python system tests on nco module #2988

Open
samsrabin opened this issue Mar 5, 2025 · 0 comments
Open

Remove dependence of Python system tests on nco module #2988

samsrabin opened this issue Mar 5, 2025 · 0 comments
Labels
bfb bit-for-bit test: python Pass clm_pymods test suite plus Python sys/unit tests before merging testing additions or changes to tests

Comments

@samsrabin
Copy link
Collaborator

These system tests fail without nco loaded, which complicates testing, especially on systems without it installed:

  • test_allInfo
  • test_modifyMesh

The issue is here:

# This could also alturnatively be done, by using the stored SCRIP grid file for the resolution under CESM inputdata
ncks_cmd = (
f"ncks --rgr infer --rgr scrip={self.scrip_file} {fsurdat_in} {self.metadata_file}"
)
try:
subprocess.check_call(ncks_cmd, shell=True)
except subprocess.CalledProcessError as e:
err_msg = (
f"{e} ERROR using ncks to generate {self.scrip_file} from "
+ f"{fsurdat_in}; MOST LIKELY SHOULD INVOKE module load nco"
)
sys.exit(err_msg)

This should be rewritten to pure Python.

@samsrabin samsrabin added bfb bit-for-bit test: python Pass clm_pymods test suite plus Python sys/unit tests before merging testing additions or changes to tests labels Mar 5, 2025
@samsrabin samsrabin added this to the ctsm6.0.0 (code freeze) milestone Mar 5, 2025
@samsrabin samsrabin changed the title Remove dependence of system tests on nco module Remove dependence of Python system tests on nco module Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bfb bit-for-bit test: python Pass clm_pymods test suite plus Python sys/unit tests before merging testing additions or changes to tests
Projects
Development

No branches or pull requests

1 participant